Change in coreboot[master]: mb/google/herobrine: consolidate hoglin/herobrine QUP inits - coreboot-gerrit

10 Mar 2022


      Attention is currently required from: mturney mturney, Ravi Kumar Bokka, Sudheer Amrabadi, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62743 )
Change subject: mb/google/herobrine: consolidate hoglin/herobrine QUP inits
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: 
Hi Qualcomm,
Can you verify that this change is ok for Hoglin?  My understanding is that the hoglin and herobrine proto1 GPIOs should be the same, so I think hoglin inits can just fall into the else clause.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62743
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48ce42760f2c75f04619b967a05909d2b3f28e2c
Gerrit-Change-Number: 62743
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 22:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment