Change in coreboot[master]: mb/google/zork: mb/google/zork: update DRAM table for morphius

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kevin Chiu (Code Review)

17 Dec 2020 17 Dec '20

7 p.m.

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

mb/google/zork: mb/google/zork: update DRAM table for morphius

Add Hynix DDR4 DRAM, index was generated by gen_part_id H5ANAG6NCJR-XNC

BUG=b:175911098 BRANCH=zork TEST=emerge-zork coreboot

Change-Id: I853a316c266afafeecff67b263005a77be316e2b Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/morphius/spd/Makefile.inc M src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48723/1

diff --git a/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc b/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc index 2eb864d..6ec9ecb 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc @@ -3,7 +3,7 @@

SPD_SOURCES = SPD_SOURCES += ddr4-spd-7.hex # ID = 0(0b0000) Parts = K4AAG165WA-BCWE -SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += ddr4-spd-9.hex # ID = 1(0b0001) Parts = H5ANAG6NCJR-XNC SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E SPD_SOURCES += ddr4-spd-1.hex # ID = 4(0b0100) Parts = K4A8G165WC-BCWE diff --git a/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt index 7210071..0ba45c5 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt @@ -8,3 +8,4 @@ K4AAG165WA-BCWE 7 (0111) H5ANAG6NCMR-XNC 8 (1000) K4A8G165WC-BCWE 9 (1001) +H5ANAG6NCJR-XNC 1 (0001) diff --git a/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt index 3297639..c4cd034 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt @@ -16,3 +16,4 @@ K4AAG165WA-BCWE, 7 H5ANAG6NCMR-XNC, 8 K4A8G165WC-BCWE, 9 +H5ANAG6NCJR-XNC

Attachments:

attachment.htm (text/html — 4.3 KB)

Show replies by date

Kevin Chiu (Code Review)

17 Dec 17 Dec

7:02 p.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Hello Furquan Shaikh, Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48723

to look at the new patch set (#2).

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

mb/google/zork: update DRAM table for morphius

Add Hynix DDR4 DRAM, index was generated by gen_part_id H5ANAG6NCJR-XNC

BUG=b:175911098 BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48723/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

7:25 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48723

to look at the new patch set (#3).

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

mb/google/zork: mb/google/zork: update DRAM table for morphius

index0 does not use in any build and add Hynix DDR4 DRAM H5ANAG6NCJR-XNC. index was generated by gen_part_id

BUG=b:175911098 BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48723/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

7:36 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48723

to look at the new patch set (#4).

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

mb/google/zork: mb/google/zork: update DRAM table for morphius

Remove index0 DRAM assignment since it doesn't use in any build.

Add Hynix DDR4 DRAM H5ANAG6NCJR-XNC, index was generated by gen_part_id

BUG=b:175911098 BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48723/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

7:50 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG@9 PS4, Line 9: Remove index0 DRAM assignment since it doesn't use in any build. Wasn't it already used in previous builds?

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Dec 2020 03:50:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

18 Dec 18 Dec

9:54 a.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG@9 PS4, Line 9: Remove index0 DRAM assignment since it doesn't use in any build.

...

Wasn't it already used in previous builds?

Hi Furquan, yes, no any build uses index0 since proto, thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Dec 2020 17:54:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Kevin Chiu (Code Review)

9:54 a.m.

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG@9 PS4, Line 9: Remove index0 DRAM assignment since it doesn't use in any build.

...

Hi Furquan, […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Dec 2020 17:54:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu kevin.chiu.17802@gmail.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:17 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 4: Code-Review+1

Looks okay to me since Kevin says that this part was *never* used. I will let Rob/Martin +2 this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 18 Dec 2020 19:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Keith Tzeng (Code Review)

20 Dec 20 Dec

11:03 p.m.

Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 4:

Please help review, thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 21 Dec 2020 07:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

21 Dec 21 Dec

3:25 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG@7 PS4, Line 7: mb/google/zork: mb/google/zork: One prefix is enough.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 21 Dec 2020 11:25:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chiu (Code Review)

4:55 a.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48723

to look at the new patch set (#5).

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

mb/google/zork: update DRAM table for morphius

Remove index0 DRAM assignment since it doesn't use in any build.

Add Hynix DDR4 DRAM H5ANAG6NCJR-XNC, index was generated by gen_part_id

BUG=b:175911098 BRANCH=zork TEST=emerge-zork coreboot

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/48723/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Kevin Chiu (Code Review)

4:55 a.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/48723/4//COMMIT_MSG@7 PS4, Line 7: mb/google/zork: mb/google/zork:

...

One prefix is enough.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 21 Dec 2020 12:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Kevin Chiu (Code Review)

22 Dec 22 Dec

5:24 p.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 5:

hi reviewers, could you please help merge this one? thank you!

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 23 Dec 2020 01:24:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rob Barnes (Code Review)

28 Dec 28 Dec

10:58 a.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 28 Dec 2020 18:58:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kevin Chiu (Code Review)

29 Dec 29 Dec

7:33 a.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

Patch Set 5:

hi reviewers, could you please help merge this one? thank you!

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 5 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 29 Dec 2020 15:33:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4 Jan 4 Jan

3:07 p.m.

New subject: Change in coreboot[master]: mb/google/zork: update DRAM table for morphius

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48723 )

Change subject: mb/google/zork: update DRAM table for morphius ......................................................................

mb/google/zork: update DRAM table for morphius

Remove index0 DRAM assignment since it doesn't use in any build.

Add Hynix DDR4 DRAM H5ANAG6NCJR-XNC, index was generated by gen_part_id

BUG=b:175911098 BRANCH=zork TEST=emerge-zork coreboot

Change-Id: I853a316c266afafeecff67b263005a77be316e2b Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48723 Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/morphius/spd/Makefile.inc M src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, but someone else must approve Rob Barnes: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc b/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc index 2eb864d..805ede4 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/morphius/spd/Makefile.inc @@ -2,7 +2,7 @@ ## This is an auto-generated file. Do not edit!!

SPD_SOURCES = -SPD_SOURCES += ddr4-spd-7.hex # ID = 0(0b0000) Parts = K4AAG165WA-BCWE +SPD_SOURCES += ddr4-spd-9.hex # ID = 0(0b0000) Parts = H5ANAG6NCJR-XNC SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = MT40A1G16KD-062E:E diff --git a/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt index 7210071..b061000 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/morphius/spd/dram_id.generated.txt @@ -1,5 +1,4 @@ DRAM Part Name ID to assign -K4AAG165WA-BCWE 0 (0000) MT40A512M16TB-062E:J 2 (0010) MT40A1G16KD-062E:E 3 (0011) K4A8G165WC-BCWE 4 (0100) @@ -8,3 +7,4 @@ K4AAG165WA-BCWE 7 (0111) H5ANAG6NCMR-XNC 8 (1000) K4A8G165WC-BCWE 9 (1001) +H5ANAG6NCJR-XNC 0 (0000) diff --git a/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt index 3297639..87bbb36 100644 --- a/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/morphius/spd/mem_parts_used.txt @@ -7,7 +7,6 @@ # See util/spd_tools/ddr4/README.md for more details and instructions.

# Part Name, Fixed ID (optional) -K4AAG165WA-BCWE, 0 MT40A512M16TB-062E:J, 2 MT40A1G16KD-062E:E, 3 K4A8G165WC-BCWE, 4 @@ -16,3 +15,4 @@ K4AAG165WA-BCWE, 7 H5ANAG6NCMR-XNC, 8 K4A8G165WC-BCWE, 9 +H5ANAG6NCJR-XNC

-- To view, visit https://review.coreboot.org/c/coreboot/+/48723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I853a316c266afafeecff67b263005a77be316e2b Gerrit-Change-Number: 48723 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com Gerrit-Reviewer: Eric Peers epeers@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Rob Barnes robbarnes@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1413

days inactive

1430

days old

coreboot-gerrit@coreboot.org

15 comments

6 participants

tags (0)

participants (6)

Furquan Shaikh (Code Review)
Keith Tzeng (Code Review)
Kevin Chiu (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Rob Barnes (Code Review)