Attention is currently required from: Tim Wawrzynczak, Angel Pons. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59000 )
Change subject: mb/google,intel: Add ChromeOS GPIOs to onboard.h ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59000/comment/e3cf9bad_007dc8b1 PS4, Line 16: #define DEVMODE_GPIO 54
I thought of keeping it, assuming the switch existed but was deprecated from depthcharge. […]
Done
File src/mainboard/google/stout/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59000/comment/5b01809c_37ae68ba PS4, Line 79: CROS_GPIO_REC_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME),
Does deduplicating this have any side-effects? At least I'd mention this change in the commit messag […]
Split to CB:59192
-
Kyösti Mälkki (Code Review)