Attention is currently required from: Alexander Couzens, Evgeny Zinoviev.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80437?usp=email )
Change subject: ec/lenovo/h8/acpi: Support pulsing LEDLOGO on Haswell ThinkPads
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/lenovo/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/80437/comment/8e038471_aa68ec59 :
PS4, Line 8: select H8_HAS_LEDLOGO
Nit: Move before H8_HAS_PRIMARY_FN_KEYS to keep the list in alphabetical order
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80437?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I85fb69c8c1bed8635a1b31e9b8385c7036bb46dd
Gerrit-Change-Number: 80437
Gerrit-PatchSet: 4
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 10 Feb 2024 19:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment