Change in coreboot[master]: mb/google/brya/variants/felwinter: Fixed stylus UI behavior bug - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: John Su, Ricky Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62638 )
Change subject: mb/google/brya/variants/felwinter: Fixed stylus UI behavior bug
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62638/comment/db4876ed_850eefc5 
PS1, Line 8: 
Maybe mention what the actual issue is? (2 issues)
Something like
1) it appears the kernel's gpio_key driver is not expecting an IRQ descriptor for the `gpio` property, therefore change to an active-low input
2) The wakeup event was configured backwards
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62638
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f5e2992584d759eb1a559684d1cda08c7cbe3f2
Gerrit-Change-Number: 62638
Gerrit-PatchSet: 1
Gerrit-Owner: John Su john_su@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Ricky Chang rickytlchang@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Frank Wu frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Attention: John Su john_su@compal.corp-partner.google.com
Gerrit-Attention: Ricky Chang rickytlchang@google.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 19:31:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment