Attention is currently required from: Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59119 )
Change subject: device/azalia_device: Drop unused function parameter ......................................................................
device/azalia_device: Drop unused function parameter
The `dev` parameter of the `azalia_codecs_init()` function is not used. Remove it, and update all call sites accordingly.
Change-Id: Idbe4a6ee5e81d5a7fd451fb83e0fe91bd0c09f0e Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/device/azalia_device.c M src/include/device/azalia_device.h M src/southbridge/intel/bd82x6x/azalia.c M src/southbridge/intel/i82801gx/azalia.c M src/southbridge/intel/i82801ix/azalia.c M src/southbridge/intel/i82801jx/azalia.c M src/southbridge/intel/ibexpeak/azalia.c 7 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/59119/1
diff --git a/src/device/azalia_device.c b/src/device/azalia_device.c index 2305101..e61e1dc 100644 --- a/src/device/azalia_device.c +++ b/src/device/azalia_device.c @@ -270,7 +270,7 @@ mainboard_azalia_program_runtime_verbs(base, reg32); }
-void azalia_codecs_init(struct device *dev, u8 *base, u16 codec_mask) +void azalia_codecs_init(u8 *base, u16 codec_mask) { int i;
@@ -300,7 +300,7 @@
if (codec_mask) { printk(BIOS_DEBUG, "azalia_audio: codec_mask = %02x\n", codec_mask); - azalia_codecs_init(dev, base, codec_mask); + azalia_codecs_init(base, codec_mask); } }
diff --git a/src/include/device/azalia_device.h b/src/include/device/azalia_device.h index d717fdd..1562e25 100644 --- a/src/include/device/azalia_device.h +++ b/src/include/device/azalia_device.h @@ -24,7 +24,7 @@ u32 azalia_find_verb(const u32 *verb_table, u32 verb_table_bytes, u32 viddid, const u32 **verb); int azalia_program_verb_table(u8 *base, const u32 *verbs, u32 verb_size); void azalia_codec_init(u8 *base, int addr, const u32 *verb_table, u32 verb_table_bytes); -void azalia_codecs_init(struct device *dev, u8 *base, u16 codec_mask); +void azalia_codecs_init(u8 *base, u16 codec_mask); void azalia_audio_init(struct device *dev); extern struct device_operations default_azalia_audio_ops;
diff --git a/src/southbridge/intel/bd82x6x/azalia.c b/src/southbridge/intel/bd82x6x/azalia.c index ae9b821..0a0b515 100644 --- a/src/southbridge/intel/bd82x6x/azalia.c +++ b/src/southbridge/intel/bd82x6x/azalia.c @@ -110,7 +110,7 @@
if (codec_mask) { printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask); - azalia_codecs_init(dev, base, codec_mask); + azalia_codecs_init(base, codec_mask); }
/* Enable dynamic clock gating */ diff --git a/src/southbridge/intel/i82801gx/azalia.c b/src/southbridge/intel/i82801gx/azalia.c index 0730744..33a0cd8 100644 --- a/src/southbridge/intel/i82801gx/azalia.c +++ b/src/southbridge/intel/i82801gx/azalia.c @@ -95,7 +95,7 @@
if (codec_mask) { printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask); - azalia_codecs_init(dev, base, codec_mask); + azalia_codecs_init(base, codec_mask); } }
diff --git a/src/southbridge/intel/i82801ix/azalia.c b/src/southbridge/intel/i82801ix/azalia.c index c929be7..26144c3 100644 --- a/src/southbridge/intel/i82801ix/azalia.c +++ b/src/southbridge/intel/i82801ix/azalia.c @@ -78,7 +78,7 @@
if (codec_mask) { printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask); - azalia_codecs_init(dev, base, codec_mask); + azalia_codecs_init(base, codec_mask); } }
diff --git a/src/southbridge/intel/i82801jx/azalia.c b/src/southbridge/intel/i82801jx/azalia.c index c637f08..bb8aec4 100644 --- a/src/southbridge/intel/i82801jx/azalia.c +++ b/src/southbridge/intel/i82801jx/azalia.c @@ -78,7 +78,7 @@
if (codec_mask) { printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask); - azalia_codecs_init(dev, base, codec_mask); + azalia_codecs_init(base, codec_mask); } }
diff --git a/src/southbridge/intel/ibexpeak/azalia.c b/src/southbridge/intel/ibexpeak/azalia.c index 32b4bb0..17db658 100644 --- a/src/southbridge/intel/ibexpeak/azalia.c +++ b/src/southbridge/intel/ibexpeak/azalia.c @@ -116,7 +116,7 @@
if (codec_mask) { printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask); - azalia_codecs_init(dev, base, codec_mask); + azalia_codecs_init(base, codec_mask); }
/* Enable dynamic clock gating */