Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Nico Huber.
Saurabh Mishra has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Thanks for your feedback, Nico. […]
Hi Nico, based on your question,
however also always
lets make invoke another shell process, just to do nothing
We can use below:
define cbfs-add-cmd
printf " CBFS $(call extract_nth,2,$(1))\n"
$(if $(3),-$(CBFSTOOL) $@.tmp remove -n $(call extract_nth,2,$(file)) 2>/dev/null, ( :) )
$(call cbfs-add-cmd-for-region,$(1),$(2))
endef
Let me know if this works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 4
Gerrit-Owner: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Mon, 19 Aug 2024 11:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Balaji Manigandan
balaji.manigandan@intel.com