Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63441 )
Change subject: mb/google/brya/var/vell: Fix camera LED flicker problem ......................................................................
Patch Set 7: Code-Review+1
(4 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/63441/comment/e070f978_e7086a31 PS5, Line 10: ,
.
Done
https://review.coreboot.org/c/coreboot/+/63441/comment/033cd303_9134864b PS5, Line 13: and prevent camera LED flicker
preventing camera LED flicker.
Done
https://review.coreboot.org/c/coreboot/+/63441/comment/bda28e34_b3775cc2 PS5, Line 16: flicker
flickers
Done
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63441/comment/33728b69_5e0744fd PS5, Line 314: register "on_seq.ops_cnt" = "4" : register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" : register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" : register "on_seq.ops[2]" = "SEQ_OPS_GPIO_DISABLE(1, 5)" : register "on_seq.ops[3]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" : : #_OFF : register "off_seq.ops_cnt" = "3" : register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" : register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" : register "off_seq.ops[2]" = "SEQ_OPS_CLK_DISABLE(0, 0)" : : device i2c 36 on end : end : chip drivers/intel/mipi_camera : register "acpi_hid" = "ACPI_DT_NAMESPACE_HID"
You do not mention these changes in the commit message.
Done
-
Shon Wang (Code Review)