[S] Change in coreboot[main]: amdfwtool: Add combo new layout for new family

[Bao Zheng (Code Review)]

Attention is currently required from: Felix Held, Marshall Dawson, Matt DeVillier.

Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84233?usp=email )

Change subject: amdfwtool: Add combo new layout for new family
......................................................................

Patch Set 7:

(4 comments)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/84233/comment/d19dbefa_1cfae50c?usp... :
PS6, Line 1594: check_new_combo_layout
> i'd rename this function to needs_new_combo_layout to clarify what it does from the name

Done

https://review.coreboot.org/c/coreboot/+/84233/comment/9f9d7c67_52e750f7?usp... :
PS6, Line 1596: if (needs_ish(soc_id))
              : 		return true;
              : 
              : 	return false;
> this can be simplified to […]

Done

https://review.coreboot.org/c/coreboot/+/84233/comment/d0964677_88390f6c?usp... :
PS6, Line 1700: 	ctx.pspdir = NULL;
> maybe add a comment why this one is moved outside of the do while loop

Done

File util/amdfwtool/data_parse.c:

https://review.coreboot.org/c/coreboot/+/84233/comment/3fc02acb_2e8bbe99?usp... :
PS6, Line 726: static bool needs_ish(enum platform platform_type)
> i'd keep this function in this file and just remove the static, so that it can be used from the othe […]

Done