Change in coreboot[master]: mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43545 )
Change subject: mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device ......................................................................
mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device
Vilboz requires a different HID than rest of the zork variants. Hence, this change sets the HID to AMDI1015 for I2S machine device in vilboz overridetree.cb.
BUG=b:157708581
Change-Id: Ibae343f21cf8f0c782dc8a461f69172bf0da7eba Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43545/1
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index d3e01e2..b2aa9e6 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -36,6 +36,24 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit + device pci 8.1 on + device pci 0.5 on + chip drivers/amd/i2s_machine_dev + register "hid" = ""AMDI1015"" + # DMIC select GPIO for ACP machine device + # This GPIO is used to select DMIC0 or DMIC1 by the + # kernel driver. It does not really have a polarity + # since low and high control the selection of DMIC and + # hence does not have an active polarity. + # Kernel driver does not use the polarity field and + # instead treats the GPIO selection as follows: + # Set low (0) = Select DMIC0 + # Set high (1) = Select DMIC1 + register "dmic_select_gpio" = "ACPI_GPIO_OUTPUT(GPIO_67)" + device generic 0.0 on end + end + end # Audio + end device pci 14.3 on # - D14F3 bridge chip ec/google/chromeec device pnp 0c09.0 on
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43545 )
Change subject: mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43545
to look at the new patch set (#6).
Change subject: mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device ......................................................................
mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device
Vilboz requires a different HID than rest of the zork variants. Hence, this change sets the HID to AMDI1015 for I2S machine device in vilboz overridetree.cb.
BUG=b:157708581
Change-Id: Ibae343f21cf8f0c782dc8a461f69172bf0da7eba Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43545/6
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43545 )
Change subject: mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device ......................................................................
mb/google/zork/var/vilboz: Use AMDI1015 HID for I2S machine device
Vilboz requires a different HID than rest of the zork variants. Hence, this change sets the HID to AMDI1015 for I2S machine device in vilboz overridetree.cb.
BUG=b:157708581
Change-Id: Ibae343f21cf8f0c782dc8a461f69172bf0da7eba Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43545 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 18 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index bc1607e..49d21d5 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -36,6 +36,24 @@ # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit + device pci 8.1 on + device pci 0.5 on + chip drivers/amd/i2s_machine_dev + register "hid" = ""AMDI1015"" + # DMIC select GPIO for ACP machine device + # This GPIO is used to select DMIC0 or DMIC1 by the + # kernel driver. It does not really have a polarity + # since low and high control the selection of DMIC and + # hence does not have an active polarity. + # Kernel driver does not use the polarity field and + # instead treats the GPIO selection as follows: + # Set low (0) = Select DMIC0 + # Set high (1) = Select DMIC1 + register "dmic_select_gpio" = "ACPI_GPIO_OUTPUT(GPIO_67)" + device generic 0.0 on end + end + end # Audio + end device pci 14.3 on # - D14F3 bridge chip ec/google/chromeec device pnp 0c09.0 on
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)