CK HU has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44434 )
Change subject: soc/mediatek/mt8192: Initialize watch dog in bootblock ......................................................................
soc/mediatek/mt8192: Initialize watch dog in bootblock
Watch dog driver would print reboot reason and disable watch dog function in coreboot.
Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: I7e849659700218f1c50365c2d68a32be2f703d94 --- M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8192/bootblock.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/44434/1
diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index 0ba9feb..2a825fb 100644 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -6,6 +6,7 @@ bootblock-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c bootblock-y += ../common/timer.c bootblock-y += ../common/uart.c +bootblock-y += ../common/wdt.c
verstage-y += ../common/gpio.c gpio.c verstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c diff --git a/src/soc/mediatek/mt8192/bootblock.c b/src/soc/mediatek/mt8192/bootblock.c index f48e78c..770c603 100755 --- a/src/soc/mediatek/mt8192/bootblock.c +++ b/src/soc/mediatek/mt8192/bootblock.c @@ -2,8 +2,10 @@
#include <bootblock_common.h> #include <soc/mmu_operations.h> +#include <soc/wdt.h>
void bootblock_soc_init(void) { mtk_mmu_init(); + mtk_wdt_init(); }
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44434 )
Change subject: soc/mediatek/mt8192: Initialize watch dog in bootblock ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44434/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44434/1//COMMIT_MSG@9 PS1, Line 9: Watch dog driver would print reboot reason and disable watch dog : function in coreboot. : Initialize watch dog so the system won't reboot on timeout.
Hello Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44434
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8192: Initialize watch dog in bootblock ......................................................................
soc/mediatek/mt8192: Initialize watch dog in bootblock
Initialize watch dog so the system won't reboot on timeout. In addition, print the reason of reboot triggered by watch dog.
Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: I7e849659700218f1c50365c2d68a32be2f703d94 --- M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8192/bootblock.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/44434/2
CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44434 )
Change subject: soc/mediatek/mt8192: Initialize watch dog in bootblock ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44434/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44434/1//COMMIT_MSG@9 PS1, Line 9: Watch dog driver would print reboot reason and disable watch dog : function in coreboot. :
Initialize watch dog so the system won't reboot on timeout.
Done
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44434 )
Change subject: soc/mediatek/mt8192: Initialize watch dog in bootblock ......................................................................
Patch Set 2: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44434 )
Change subject: soc/mediatek/mt8192: Initialize watch dog in bootblock ......................................................................
soc/mediatek/mt8192: Initialize watch dog in bootblock
Initialize watch dog so the system won't reboot on timeout. In addition, print the reason of reboot triggered by watch dog.
Signed-off-by: CK Hu ck.hu@mediatek.com Change-Id: I7e849659700218f1c50365c2d68a32be2f703d94 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44434 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/soc/mediatek/mt8192/Makefile.inc M src/soc/mediatek/mt8192/bootblock.c 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc index 0ba9feb..2a825fb 100644 --- a/src/soc/mediatek/mt8192/Makefile.inc +++ b/src/soc/mediatek/mt8192/Makefile.inc @@ -6,6 +6,7 @@ bootblock-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c bootblock-y += ../common/timer.c bootblock-y += ../common/uart.c +bootblock-y += ../common/wdt.c
verstage-y += ../common/gpio.c gpio.c verstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c diff --git a/src/soc/mediatek/mt8192/bootblock.c b/src/soc/mediatek/mt8192/bootblock.c index f48e78c..770c603 100644 --- a/src/soc/mediatek/mt8192/bootblock.c +++ b/src/soc/mediatek/mt8192/bootblock.c @@ -2,8 +2,10 @@
#include <bootblock_common.h> #include <soc/mmu_operations.h> +#include <soc/wdt.h>
void bootblock_soc_init(void) { mtk_mmu_init(); + mtk_wdt_init(); }
-
CK HU (Code Review) -
Hung-Te Lin (Code Review)