Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Michał Zieliński, Patrick Rudolph.
Felix Singer has posted comments on this change by Michał Zieliński. ( https://review.coreboot.org/c/coreboot/+/67666?usp=email )
Change subject: mb/hp: Add HP Compaq 8300 Elite SFF ......................................................................
Patch Set 5:
(5 comments)
Patchset:
PS5: Hi @Michał, are you still interested in finishing this port?
File src/mainboard/hp/compaq_8300_elite_sff/Kconfig:
https://review.coreboot.org/c/coreboot/+/67666/comment/8e79435e_89f0e4a7?usp... : PS5, Line 33: int Avoid retyping, remove.
https://review.coreboot.org/c/coreboot/+/67666/comment/0c22ee6f_46781a50?usp... : PS5, Line 37: int Avoid retyping, remove.
File src/mainboard/hp/compaq_8300_elite_sff/Makefile.inc:
PS5: Needs to be renamed to Makefile.mk
File src/mainboard/hp/compaq_8300_elite_sff/early_init.c:
https://review.coreboot.org/c/coreboot/+/67666/comment/11aa003d_e0126c18?usp... : PS5, Line 11: const struct southbridge_usb_port mainboard_usb_ports[] = { : { 1, 0, 0 }, : { 1, 0, 0 }, : { 1, 0, 1 }, : { 1, 0, 1 }, : { 1, 0, 2 }, : { 1, 0, 2 }, : { 1, 0, 3 }, : { 1, 0, 3 }, : { 1, 1, 4 }, : { 1, 0, 4 }, : { 1, 0, 6 }, : { 1, 0, 5 }, : { 1, 0, 5 }, : { 1, 0, 6 }, : }; USB ports are configured in devicetree now. Please have a look at hp/snb_ivb_desktops.