[M] Change in coreboot[master]: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C ...

[CoolStar (Code Review)]

Attention is currently required from: CoolStar, Martin Roth, Matt DeVillier, Stefan Reinauer.

Hello Martin Roth, Matt DeVillier, Stefan Reinauer, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/76159?usp=email

to look at the new patch set (#5).

Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver
......................................................................

mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver

This is a brand new I2C driver that is designed specifically for the Pixel 2013 chromebook (LINK). The GMBus interface on the IGPU is an i2c-compatible interface, but AFAIK only Link has touch devices attached in this way.

On Windows, the PCIe device for the IGP is owned by the Intel proprietary driver, hence a separate ACPI device has to be added for the I2C driver arbitrator to attach to. The MMIO method is used instead of _CRS so that Windows does not try to assign ownership of the resource to our device (even though we're using the MMIO registers at the same time as the IGP driver).

Even though in theory 2 drivers accessing the same MMIO may cause problems, in testing, there has been no issues with sleep/wake/hibernate, updating/installing/uninstalling the IGP driver, or changing display resolutions with the i2c driver attached.

The arbitrator is necessary as well, since even though there are multiple i2c buses, the MMIO registers are shared. Hence a shared lock is required for i2c access across the buses.

The original Sleep Button devices are preserved for Linux due to the completely custom and non-standard implementation of the Windows driver in order to work around the non-standard nature of Link's hardware.

Change-Id: If7ee05d15bc17d335cf8c1a8e80bea62800de475
Signed-off-by: CoolStar 
---
M src/mainboard/google/link/acpi/mainboard.asl
M src/mainboard/google/link/dsdt.asl
M src/mainboard/google/link/onboard.h
3 files changed, 114 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/76159/5