Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Paul Menzel, Subrata Banik.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84359/comment/1e7ab28d_9f445450?usp... : PS1, Line 9: significantly impacts : boot time negatively
It’d be great to have numbers in the commit message.
I'm not sitting here with a stopwatch, but it's an order of magnitude (ie, 10s vs 1s)
https://review.coreboot.org/c/coreboot/+/84359/comment/f5e25250_64c52a76?usp... : PS1, Line 10: breaks USB detection in edk2 payload
Does Linux detect it? Any logs for the record?
the device was effectively unusable as it didn't have an OS installed on internal storage
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/84359/comment/7f4cffd9_af186f9e?usp... : PS1, Line 39: select SOC_INTEL_CRASHLOG
that doesn't help, since `MAINBOARD_HAS_CHROMEOS` is already selected above -- it would enable it even for non-ChromeOS builds, just like it already is.