Change in coreboot[master]: soc/mediatek/mt8192: Add multi freq calibration

[Yidi Lin (Code Review)]

Hello Xi Chen,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/46398

to review the following change.

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

soc/mediatek/mt8192: Add multi freq calibration

For calibration highest freq.

Signed-off-by: mtk11206 
Change-Id: Iddab4dd1a331c668b967207e7f1542ea29424b68
---
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8192/dramc_pi_main.c
M src/soc/mediatek/mt8192/include/soc/dramc_param.h
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/46398/1

diff --git a/src/soc/mediatek/mt8192/Kconfig b/src/soc/mediatek/mt8192/Kconfig
index ea82a8b..6723cc5 100644
--- a/src/soc/mediatek/mt8192/Kconfig
+++ b/src/soc/mediatek/mt8192/Kconfig
@@ -38,7 +38,7 @@

config MT8192_DRAM_DVFS_LIMIT_FREQ_CNT
    bool
-	default n
+	default y
    select MT8192_DRAM_DVFS
    help
      This options limit DRAM frequency calibration count from total 7 to 3,
diff --git a/src/soc/mediatek/mt8192/dramc_pi_main.c b/src/soc/mediatek/mt8192/dramc_pi_main.c
old mode 100644
new mode 100755
index e4772c2..e7c6ecb
--- a/src/soc/mediatek/mt8192/dramc_pi_main.c
+++ b/src/soc/mediatek/mt8192/dramc_pi_main.c
@@ -480,7 +480,7 @@
    after_calib(&cali);
    enable_dfs_hw_mode_clk();

-	if (CONFIG(MT8192_DRAM_DVFS)) {
+	if (CONFIG(MT8192_DRAM_DVFS) || CONFIG(MT8192_DRAM_DVFS_LIMIT_FREQ_CNT)) {
    	dram_cali_seq bootup_cali_seq = CALI_SEQ5;
    	dram_dfs_shu bootup_shu = get_shu_save_by_k_shu(bootup_cali_seq);

diff --git a/src/soc/mediatek/mt8192/include/soc/dramc_param.h b/src/soc/mediatek/mt8192/include/soc/dramc_param.h
old mode 100644
new mode 100755
index b4e982f..2d4f2ca
--- a/src/soc/mediatek/mt8192/include/soc/dramc_param.h
+++ b/src/soc/mediatek/mt8192/include/soc/dramc_param.h
@@ -8,7 +8,7 @@
 #include <soc/dramc_common_mt8192.h>

enum {
-	DRAMC_PARAM_HEADER_VERSION = 3,
+	DRAMC_PARAM_HEADER_VERSION = 4,
 };

enum DRAMC_PARAM_STATUS_CODES {

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46398 )

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46398/4/src/soc/mediatek/mt8192/Kco... 
File src/soc/mediatek/mt8192/Kconfig:

https://review.coreboot.org/c/coreboot/+/46398/4/src/soc/mediatek/mt8192/Kco... 
PS4, Line 44: This options limit
This option limits …

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46398 )

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46398/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46398/4//COMMIT_MSG@7 
PS4, Line 7: soc/mediatek/mt8192: Add multi freq calibration
Default to …

[Yidi Lin (Code Review)]

Hello Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46398

to look at the new patch set (#22).

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

soc/mediatek/mt8192: Add multi freq calibration

For calibration highest freq.

Signed-off-by: mtk11206 
Change-Id: Iddab4dd1a331c668b967207e7f1542ea29424b68
---
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8192/dramc_pi_main.c
M src/soc/mediatek/mt8192/include/soc/dramc_param.h
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/46398/22

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46398 )

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

Patch Set 30:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46398/30/src/soc/mediatek/mt8192/dr... 
File src/soc/mediatek/mt8192/dramc_pi_main.c:

PS30: 
Yidi, about the file permission, please run `make gitconfig` in coreboot/, so that pre-commit hook will be installed in coreboot/.git/hooks/ (see [1]). Then, `git commit` will fail if files have wrong permission set. This will also save a great amount of time in the code review process.

Please forward this message to the rest of the team, especially to the people actually doing `git commit`.

[1] https://doc.coreboot.org/tutorial/part2.html#step-3-clone-coreboot-and-confi...

[Yidi Lin (Code Review)]

Hello Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46398

to look at the new patch set (#31).

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

soc/mediatek/mt8192: Add multi freq calibration

For calibration highest freq.

Signed-off-by: mtk11206 
Change-Id: Iddab4dd1a331c668b967207e7f1542ea29424b68
---
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8192/dramc_pi_main.c
M src/soc/mediatek/mt8192/include/soc/dramc_param.h
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/46398/31

[Yidi Lin (Code Review)]

Hello Hung-Te Lin, Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46398

to look at the new patch set (#32).

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

soc/mediatek/mt8192: Add multi freq calibration

For calibration highest freq.

Signed-off-by: mtk11206 
Change-Id: Iddab4dd1a331c668b967207e7f1542ea29424b68
---
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8192/dramc_pi_main.c
M src/soc/mediatek/mt8192/include/soc/dramc_param.h
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/46398/32

[Yidi Lin (Code Review)]

Hello Hung-Te Lin, Xi Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46398

to look at the new patch set (#34).

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

soc/mediatek/mt8192: Add multi freq calibration

For calibration highest freq.

Signed-off-by: mtk11206 
Change-Id: Iddab4dd1a331c668b967207e7f1542ea29424b68
---
M src/soc/mediatek/mt8192/Kconfig
M src/soc/mediatek/mt8192/dramc_pi_main.c
M src/soc/mediatek/mt8192/include/soc/dramc_param.h
3 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/46398/34

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46398 )

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

Patch Set 38:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46398/38//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46398/38//COMMIT_MSG@11 
PS38, Line 11: mtk11206
Ditto as in other change-set.

[Hung-Te Lin (Code Review)]

Attention is currently required from: Yidi Lin.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46398 )

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

Patch Set 45:

(1 comment)

Patchset:

PS45: 
abandon this?

[Yidi Lin (Code Review)]

Yidi Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46398 )

Change subject: soc/mediatek/mt8192: Add multi freq calibration
......................................................................

Abandoned