Attention is currently required from: Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63561 )
Change subject: drivers/i2c/dw_i2c: Adjust to handle 0-byte transfers ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/63561/comment/d5633343_3d0b81ef PS1, Line 377: if (segments->len == 0)
not necessarily - you still need at least 1 segment even with a zero-byte xfer, to define the slave […]
Ack
https://review.coreboot.org/c/coreboot/+/63561/comment/4db75a59_3861149e PS1, Line 431: if (segments->len != 0) I think it's OK to still print the message in the 0-byte write case
-
Tim Wawrzynczak (Code Review)