Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62972 )
Change subject: [TEST] soc/intel/alderlake:set slopes,enable ER & RTH ......................................................................
Patch Set 1:
(9 comments)
File src/soc/intel/alderlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/bdcc9a79_5d0e1a36 PS1, Line 726: s_cfg->PchPmDisableEnergyReport = 0x0; trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/a06e2e26_5741d0e8 PS1, Line 727: s_cfg->RaceToHalt = 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/4ace51a9_85756b2c PS1, Line 727: s_cfg->RaceToHalt = 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/954e0743_b7e223a9 PS1, Line 728: s_cfg->ImonSlope[0] = 143; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/52f24a15_a6c315b4 PS1, Line 728: s_cfg->ImonSlope[0] = 143; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/b29b6c93_3d54d01d PS1, Line 729: s_cfg->ImonSlope[1] = 103; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/ffaa8bc8_83f22a71 PS1, Line 729: s_cfg->ImonSlope[1] = 103; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/831bb9a7_4d59e0ae PS1, Line 730: s_cfg->VccInAuxImonSlope = 111; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144388): https://review.coreboot.org/c/coreboot/+/62972/comment/4814a225_9efe43a1 PS1, Line 730: s_cfg->VccInAuxImonSlope = 111; please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)