Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, ritul guru.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83740?usp=email )
Change subject: soc/amd/common/psp_smi: implement P2C mailbox handling ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS4:
it's software that talks to the other psp mailbox, so i'd say that it should be in amd/common/block/ […]
i'd like to keep this in this folder, since it belongs thematically to the other files in there and also uses a local header file shared by the files in that folder
File src/soc/amd/common/block/psp/psp_smi.c:
https://review.coreboot.org/c/coreboot/+/83740/comment/baee5751_311dcbf5?usp... : PS4, Line 33: tmp
Nit: I know that the union is already named status, but why tmp and not something like 'status'? I m […]
good point; done
https://review.coreboot.org/c/coreboot/+/83740/comment/e49938f8_d2f380d2?usp... : PS4, Line 80: u32
Nit: this seems to use a mix of u8/u32 and uint8_t/uint32_t. […]
the existing parts of the psp code in coreboot already use a mix of both; i can look into using only one type in some follow up in the future, but would prefer to not change this right now, since the scope is larger than just what gets added here. marking this as resolved for now