Attention is currently required from: Andrey Petrov, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76921/comment/41c46feb_c9327bd0 : PS3, Line 18: It also adds a : new config (BMP_LOGO_TO_GOP_BLT) to ensure backward compatibility with : older generation FSP.
Can’t this (the FSP version) be detected at runtime? […]
I meant, if `BMP_LOGO` is selected, then build in the BMP to GOP BLT conversion always.
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
PS3:
How special is `efi_bmp_image_header`? Otherwise most of these functions (check, if the image is v […]
Maybe the same structs could be used for coreboot in general, and then only the structs are converted, and the newly added function would be common code. coreboot’s splash screen feature also supports BMP, so having a checker for that could be used there too.