Attention is currently required from: Elyes Haouas.
Julius Werner has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83503?usp=email )
Change subject: azalia: Get rid of "return {-1,0}
......................................................................
Patch Set 5:
(1 comment)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/83503/comment/8bbada03_23cd4f54?usp... :
PS5, Line 56: if (azalia_exit_reset(base) == CB_ERR)
You should still test cb_errs for failure with `< 0` or `!= CB_SUCCESS`, unless you're really only looking for one specific error code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83503?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icea33ea3e6a5e3c7bbfedc29045026cd722ac23e
Gerrit-Change-Number: 83503
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 18 Jul 2024 22:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No