Attention is currently required from: Martin L Roth, Marshall Dawson, Nikolai Vyssotski, Andrey Petrov, Matt Papageorge, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51061 )
Change subject: drivers/intel/fsp2_0: Add support for locating specific HOB instance
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
have a look at find_resource_hob_by_guid above
this comment still applies. if you want me to have a look into this and update the patch accordingly, i could do that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I695f0d1574a59e65f01d12561a2c2f6142cac44d
Gerrit-Change-Number: 51061
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 26 Oct 2022 16:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment