Attention is currently required from: Lance Zhao, Martin Roth, Tim Wawrzynczak, Julius Werner. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 )
Change subject: acpi,Makefile: Add preload_acpi_dsdt ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I kind of agree with Tim's sentiment, having each platform kick all of these off manually gets prett […]
The order right now has been hand crafted and analyzed extensively. The biggest problem we run into is having a SPI DMA transaction in flight while something else tries to access the SPI rom. i.e., if we have a SPI DMA transaction in flight while ELOG or APOB is writing, then they will be blocked unnecessarily and thus negate any benefits. I moved the APOB update into romstage to make the sequencing easier.
Also by sequencing the preloads the way I did, I can make sure we don't exhaust the cbfs_cache. Some platforms might need to load additional files between two "generic" preloads. So I'm still a little hesitant to make the whole thing generic.
I think Tim's point was more having these functions in the first place. imo, they are better then copy/pasting the code that derives the cbfs filename.
-
Raul Rangel (Code Review)