Attention is currently required from: Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80598?usp=email )
Change subject: device/pnp_device: Skip init on disabled functions ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80598/comment/ae3dc7f6_0090738c : PS1, Line 11: any resources to that function. The code disabled here merely attaches the structures for the resources. Resource assignment would happen later and should happen only if an LDN is enabled.
https://review.coreboot.org/c/coreboot/+/80598/comment/c07073d9_c41be90a : PS1, Line 15: in the log / don't cause any errors. Can you share a log? errors are often because of mistakes in the devicetree.
File src/device/pnp_device.c:
https://review.coreboot.org/c/coreboot/+/80598/comment/4a3e3e3e_0b2832a3 : PS1, Line 403: dev->ops = ops; Not setting the ops has certain side effects. For instance one couldn't generate SSDT entries for disabled devices. So skipping this seems wrong. Do I miss something?