Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
soc/amd/picasso: add missing GNB I/O APIC initialization
In order for this to really work, the GNB I/O APIC initialization part in FSP that enables the hardware unit and configures its base address need to be fixed too.
Change-Id: Iddb0c20e769e6921ba5d0dd4a84ab9e494d522e1 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/root_complex.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48269/1
diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 72a0974..f477a73 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpigen.h> +#include <arch/ioapic.h> #include <assert.h> #include <cbmem.h> #include <console/console.h> @@ -181,6 +182,11 @@ gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; }
+static void root_complex_init(struct device *dev) +{ + setup_ioapic((u8 *)GNB_IO_APIC_ADDR, CONFIG_PICASSO_GNB_IOAPIC_ID); +} + static void dptc_call_alib(const char *buf_name, uint8_t *buffer, size_t size) { /* Name (buf_name, Buffer(size) {...} */ @@ -265,6 +271,7 @@ static struct device_operations root_complex_operations = { .read_resources = read_resources, .enable_resources = pci_dev_enable_resources, + .init = root_complex_init, .acpi_fill_ssdt = root_complex_fill_ssdt, };
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
Patch Set 1: Code-Review-1
we should probably wait with submitting this until the corresponding FSP-side patch has landed
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
Patch Set 1: Code-Review+1
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
Patch Set 2: Code-Review+2
Patch Set 1: Code-Review-1
we should probably wait with submitting this until the corresponding FSP-side patch has landed
These have landed. I think we should merge this now.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Nikolai Vyssotski,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48269
to look at the new patch set (#4).
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
soc/amd/picasso: add missing GNB I/O APIC initialization
Change-Id: Iddb0c20e769e6921ba5d0dd4a84ab9e494d522e1 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/root_complex.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48269/4
Felix Held has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
Removed Code-Review-1 by Felix Held felix-coreboot@felixheld.de
Attention is currently required from: Felix Held. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
Patch Set 4: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48269 )
Change subject: soc/amd/picasso: add missing GNB I/O APIC initialization ......................................................................
soc/amd/picasso: add missing GNB I/O APIC initialization
Change-Id: Iddb0c20e769e6921ba5d0dd4a84ab9e494d522e1 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48269 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/root_complex.c 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Raul Rangel: Looks good to me, approved Nikolai Vyssotski: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 045f30c..5166fe5 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <acpi/acpigen.h> +#include <arch/ioapic.h> #include <assert.h> #include <cbmem.h> #include <console/console.h> @@ -181,6 +182,11 @@ gnb_apic->flags = IORESOURCE_MEM | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; }
+static void root_complex_init(struct device *dev) +{ + setup_ioapic((u8 *)GNB_IO_APIC_ADDR, CONFIG_PICASSO_GNB_IOAPIC_ID); +} + static void dptc_call_alib(const char *buf_name, uint8_t *buffer, size_t size) { /* Name (buf_name, Buffer(size) {...} */ @@ -266,6 +272,7 @@ .read_resources = read_resources, .set_resources = noop_set_resources, .enable_resources = pci_dev_enable_resources, + .init = root_complex_init, .acpi_fill_ssdt = root_complex_fill_ssdt, };
-
Felix Held (Code Review) -
Marshall Dawson (Code Review)
-
Nikolai Vyssotski (Code Review)
-
Raul Rangel (Code Review)