Change in coreboot[master]: soc/intel/{skl,cnl,icl,jsl,elh,tgl}: make XTAL in s0ix conditional

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45723 )

Change subject: soc/intel/{skl,cnl,icl,jsl,elh,tgl}: make XTAL in s0ix conditional
......................................................................

Patch Set 2:

(3 comments)

Code changes look good.

https://review.coreboot.org/c/coreboot/+/45723/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45723/2//COMMIT_MSG@16 
PS2, Line 16: This patch adds a new devicetree option for XTAL (dis)qualification and
Disqualificaton of shutting something down is not exactly the same
as qualification of the thing. If you want to use Intel's (complex)
terms, please use them exactly.

https://review.coreboot.org/c/coreboot/+/45723/2//COMMIT_MSG@20 
PS2, Line 20: change.
Generally, if you want separate commits and things to be regression free
in between, the order should be reversed. First add the option and set it
for the boards, then update the logic.

https://review.coreboot.org/c/coreboot/+/45723/2/src/soc/intel/cannonlake/ch... 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/c/coreboot/+/45723/2/src/soc/intel/cannonlake/ch... 
PS2, Line 60: 	/* Enable XTAL oscillator qualification for S0ix */
The comment is neither accurate nor necessary. If you want to avoid to
simply repeat the option name, just don't add a comment.