Attention is currently required from: Werner Zeh.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 )
Change subject: drivers/phy/m88e1512: Provide functionality to customize LED status ......................................................................
Patch Set 7:
(1 comment)
File src/drivers/phy/m88e1512/m88e1512.c:
https://review.coreboot.org/c/coreboot/+/69386/comment/28c6a427_4278c1a0 PS6, Line 34: /* Set INTn output to be brought out on LED[2]. */ : page_reg = mdio_ops->read(parent, dev->path.pnp.device, : LED_TIMER_CTRL_REG); : setbits16(&page_reg, (config->irq_led_2_enable << 7)); : mdio_ops->write(parent, dev->path.pnp.device, LED_TIMER_CTRL_REG, : page_reg);
This should be a separate setting as we need to keep cases in mind where a board can have connected […]
Ack. I will make a separate commit for this.