Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29106 )
Change subject: lib/ramtest: Use Kconfig switch CONFIG_RAMBASE for RAM test
......................................................................
Patch Set 2:
Patch Set 2:
With the few remaining quick_ram_check() calls, I think checking memory near CBMEM / IMD root would be good option.
Sounds like a good idea as the first thing placed in RAM is cbmem right after memory init.
Except ith FSP 1.0, by the time we return from raminit, CAR is already torn down and our stack is in RAM. So yeah... can't test RAM before utilising it so I quess it will die silently with postcode (unless there is serial debug from FSP).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc57e684a677ac64225ea54cb43e6fbb68930354
Gerrit-Change-Number: 29106
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 13 Mar 2019 12:01:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment