Change in coreboot[master]: mb/google/dedede: Elan touchscreen IRQ is level type

[Evan Green (Code Review)]

Evan Green has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47544 )

Change subject: mb/google/dedede: Elan touchscreen IRQ is level type
......................................................................

mb/google/dedede: Elan touchscreen IRQ is level type

Apparently Elan touchscreens have level-sensitive interrupts, not edge.
Fix up all instances in the dedede family.

BUG=b:172609391 b:172642296
TEST=Try pen on draw*, waddledoo

Signed-off-by: Evan Green 
Change-Id: I8704ad7563cdbf981be95cfc1ac666894c956d7d
---
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
M src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
3 files changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/47544/1

diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
index 574ae38..fab11a5 100644
--- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
@@ -159,7 +159,7 @@
    		chip drivers/i2c/generic
    			register "hid" = ""ELAN0001""
    			register "desc" = ""ELAN Touchscreen""
-				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
    			register "probed" = "1"
    			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)"
    			register "reset_delay_ms" = "20"
@@ -199,7 +199,7 @@
    		chip drivers/i2c/hid
    			register "generic.hid" = ""ELAN2513""
    			register "generic.desc" = ""ELAN Touchscreen""
-				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
    			register "generic.probed" = "1"
    			register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D5)"
    			register "generic.reset_delay_ms" = "20"
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
index 33b89d6..c150f01 100644
--- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb
@@ -169,7 +169,7 @@
    		chip drivers/i2c/hid
    			register "generic.hid" = ""ELAN6915""
    			register "generic.desc" = ""ELAN Touchscreen""
-				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
    			register "generic.probed" = "1"
    			register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
    			register "generic.reset_delay_ms" = "20"
@@ -187,7 +187,7 @@
    		chip drivers/i2c/generic
    			register "hid" = ""ELAN0001""
    			register "desc" = ""ELAN Touchscreen""
-				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
    			register "probed" = "1"
    			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"
    			register "reset_delay_ms" = "20"
diff --git a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
index c306b52..ede0ea6 100644
--- a/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
@@ -119,7 +119,7 @@
    		chip drivers/i2c/hid
    			register "generic.hid" = ""ELAN9050""
    			register "generic.desc" = ""ELAN Touchscreen""
-				register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)"
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)"
    			register "generic.probed" = "1"
    			register "generic.reset_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)"

[Evan Green (Code Review)]

Evan Green has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47544 )

Change subject: mb/google/dedede: Elan touchscreen IRQ is level type
......................................................................

Abandoned

Covered in https://review.coreboot.org/c/coreboot/+/47544

[Evan Green (Code Review)]

Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47544 )

Change subject: mb/google/dedede: Elan touchscreen IRQ is level type
......................................................................

Patch Set 1:

err rather https://review.coreboot.org/c/coreboot/+/47415