Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59608 )
Change subject: driver/i2c: Add sx9360 driver ......................................................................
Patch Set 2:
(2 comments)
File src/drivers/i2c/sx9360/sx9360.c:
PS2:
This looks very similar to `src/drivers/i2c/sx9324/sx9324.c`. […]
It is actually closer to sx9310 current driver. I am working to make sx9324 look like sx9310 as well. I can combine them into one, but we are not saving much code. chip.h will become:
struct drivers_i2c_sx93xx_config { ## common const char *desc; ... struct acpi_irq irq;
## different union { struct { ## 5 params } sx9310 struct { ## 4 params } sx9324 struct { ## 3 params } sx9360 } prop }
Some parameters are found in different Semtech sensors, but they are used slightly differently. IMHO, the removed common code will not offset the added complexity.
https://review.coreboot.org/c/coreboot/+/59608/comment/a715a341_824756e6 PS2, Line 15: REGISTER
This looks unused, and not particularly worth it for 3 parameters? […]
It is unused, I should have removed it when copied the code from sx9324.