Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/85537?usp=email )
Change subject: mb/google/brya/uldrenite: Add WWAN RW350R-GL power on sequence
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85537/comment/c7e6c232_a1fb0b94?usp... :
PS3, Line 9: support
support*s*
https://review.coreboot.org/c/coreboot/+/85537/comment/15c0003f_d459ce7c?usp... :
PS3, Line 11:
Please document the source for the sequence.
https://review.coreboot.org/c/coreboot/+/85537/comment/48f49852_e2d21eb6?usp... :
PS3, Line 14: TEST=emerge-nissa coreboot
Is the boot time affected? Please mention the total time before and after.
File src/mainboard/google/brya/variants/uldrenite/variant.c:
https://review.coreboot.org/c/coreboot/+/85537/comment/485157c2_407c4379?usp... :
PS3, Line 27: * RW350R power on seuqence:
: * De-assert WWAN_EN -> 20ms -> de-assert WWAN_RST -> 30ms ->
: * de-assert WWAN_PERST
: */
The asterisks need to be aligned with the very first one.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85537?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If8695920c2b3d2a27da62afcbe75e70d1ea09792
Gerrit-Change-Number: 85537
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 10 Dec 2024 08:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No