Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43532 )
Change subject: ec/google/chromeec: Fix a oversights in ec_dptf_helpers ......................................................................
ec/google/chromeec: Fix a oversights in ec_dptf_helpers
GTSH was 2 instead of 20 (so it's 2 degrees K hysteresis), and TSRD was accidentally defined to take 0 arguments, instead of 1.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I14d28bacf44ac65043060b8579b3fbcec758c56c --- M src/ec/google/chromeec/ec_dptf_helpers.c 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/43532/1
diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c index 05bbae5..c54d532 100644 --- a/src/ec/google/chromeec/ec_dptf_helpers.c +++ b/src/ec/google/chromeec/ec_dptf_helpers.c @@ -262,7 +262,7 @@
/* TEVT */ if (CONFIG(EC_SUPPORTS_DPTF_TEVT)) { - acpigen_write_method("TEVT", 0); + acpigen_write_method("TEVT", 1);
/* Local0 = ToInteger(Arg0) */ acpigen_write_to_integer(ARG0_OP, LOCAL0_OP); @@ -308,8 +308,11 @@ { dptf_write_scope(participant);
- /* GTSH - Amount of hysteresis inherent in temperature reading */ - acpigen_write_name_integer("GTSH", 2); + /* + * GTSH - Amount of hysteresis inherent in temperature reading (2 degrees, in units of + * 1/10th degree K) + */ + acpigen_write_name_integer("GTSH", 20);
/* _TMP - read temperature from EC */ acpigen_write_method_serialized("_TMP", 0);
Hello Duncan Laurie, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43532
to look at the new patch set (#2).
Change subject: ec/google/chromeec: Fix oversights in ec_dptf_helpers ......................................................................
ec/google/chromeec: Fix oversights in ec_dptf_helpers
GTSH was 2 instead of 20 (so it's 2 degrees K hysteresis), and TSRD was accidentally defined to take 0 arguments, instead of 1.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I14d28bacf44ac65043060b8579b3fbcec758c56c --- M src/ec/google/chromeec/ec_dptf_helpers.c 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/43532/2
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43532 )
Change subject: ec/google/chromeec: Fix oversights in ec_dptf_helpers ......................................................................
Patch Set 3: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43532 )
Change subject: ec/google/chromeec: Fix oversights in ec_dptf_helpers ......................................................................
ec/google/chromeec: Fix oversights in ec_dptf_helpers
GTSH was 2 instead of 20 (so it's 2 degrees K hysteresis), and TSRD was accidentally defined to take 0 arguments, instead of 1.
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: I14d28bacf44ac65043060b8579b3fbcec758c56c Reviewed-on: https://review.coreboot.org/c/coreboot/+/43532 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/ec/google/chromeec/ec_dptf_helpers.c 1 file changed, 6 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c index 8bb3435..0f8d4a3 100644 --- a/src/ec/google/chromeec/ec_dptf_helpers.c +++ b/src/ec/google/chromeec/ec_dptf_helpers.c @@ -262,7 +262,7 @@
/* TEVT */ if (CONFIG(EC_SUPPORTS_DPTF_TEVT)) { - acpigen_write_method("TEVT", 0); + acpigen_write_method("TEVT", 1);
/* Local0 = ToInteger(Arg0) */ acpigen_write_to_integer(ARG0_OP, LOCAL0_OP); @@ -308,8 +308,11 @@ { dptf_write_scope(participant);
- /* GTSH - Amount of hysteresis inherent in temperature reading */ - acpigen_write_name_integer("GTSH", 2); + /* + * GTSH - Amount of hysteresis inherent in temperature reading (2 degrees, in units of + * 1/10th degree K) + */ + acpigen_write_name_integer("GTSH", 20);
/* _TMP - read temperature from EC */ acpigen_write_method_serialized("_TMP", 0);
-
Karthik Ramasubramanian (Code Review) -
Tim Wawrzynczak (Code Review)