Change in ...coreboot[master]: SMBUS: Update BMC Interface Type field

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

14 Feb 2019 14 Feb '19

3:50 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31421

Change subject: SMBUS: Update BMC Interface Type field ......................................................................

SMBUS: Update BMC Interface Type field

Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 4 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31421/1

diff --git a/src/include/smbios.h b/src/include/smbios.h index 14badbc..da92315 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -481,9 +481,10 @@

enum smbios_bmc_interface_type { SMBIOS_BMC_INTERFACE_UNKNOWN = 0, - SMBIOS_BMC_INTERFACE_KCS, - SMBIOS_BMC_INTERFACE_SMIC, - SMBIOS_BMC_INTERFACE_BLOCK, + SMBIOS_BMC_INTERFACE_KCS = 0x01, + SMBIOS_BMC_INTERFACE_SMIC = 0x02, + SMBIOS_BMC_INTERFACE_BLOCK = 0x03, + SMBIOS_BMC_INTERFACE_SMBUS = 0x04, };

typedef enum {

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

HAOUAS Elyes (Code Review)

14 Feb 14 Feb

3:56 p.m.

New subject: Change in ...coreboot[master]: SMBIOS: Update BMC Interface Type field

Hello Richard Spiegel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31421

to look at the new patch set (#2).

Change subject: SMBIOS: Update BMC Interface Type field ......................................................................

SMBIOS: Update BMC Interface Type field

Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 4 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31421/2

Richard Spiegel (Code Review)

4:08 p.m.

New subject: Change in ...coreboot[master]: SMBIOS: Update BMC Interface Type field

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31421 )

Change subject: SMBIOS: Update BMC Interface Type field ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31421/2/src/include/smbios.h File src/include/smbios.h:

https://review.coreboot.org/#/c/31421/2/src/include/smbios.h@484 PS2, Line 484: SMBIOS_BMC_INTERFACE_KCS = 0x01, : SMBIOS_BMC_INTERFACE_SMIC = 0x02, : SMBIOS_BMC_INTERFACE_BLOCK = 0x03, : SMBIOS_BMC_INTERFACE_SMBUS = 0x04, : The equates are not needed, this is an enum. SMBIOS_BMC_INTERFACE_UNKNOWN = 0, SMBIOS_BMC_INTERFACE_KCS, SMBIOS_BMC_INTERFACE_SMIC, SMBIOS_BMC_INTERFACE_BLOCK, SMBIOS_BMC_INTERFACE_SMBUS, }}

-- To view, visit https://review.coreboot.org/c/coreboot/+/31421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Gerrit-Change-Number: 31421 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 14 Feb 2019 16:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:15 p.m.

New subject: Change in ...coreboot[master]: SMBIOS: Update BMC Interface Type field

Hello Richard Spiegel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31421

to look at the new patch set (#3).

Change subject: SMBIOS: Update BMC Interface Type field ......................................................................

SMBIOS: Update BMC Interface Type field

Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/smbios.h 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31421/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Gerrit-Change-Number: 31421 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Richard Spiegel (Code Review)

4:21 p.m.

New subject: Change in ...coreboot[master]: SMBIOS: Update BMC Interface Type field

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31421 )

Change subject: SMBIOS: Update BMC Interface Type field ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Gerrit-Change-Number: 31421 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 14 Feb 2019 16:21:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

4:30 p.m.

New subject: Change in ...coreboot[master]: SMBIOS: Update BMC Interface Type field

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31421 )

Change subject: SMBIOS: Update BMC Interface Type field ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31421/2/src/include/smbios.h File src/include/smbios.h:

...

The equates are not needed, this is an enum. […]

Binaries are fine without the equates here, but only because the particular enumeration here does not have any gaps.

You can notice many of the other enums in this file actually have these equates even for cases without gaps. Like smbios_memory_bus_width and smbios_memory_array_ecc. That's because this has to meet external specification and source is more readable with than without them.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Gerrit-Change-Number: 31421 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Thu, 14 Feb 2019 16:30:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

15 Feb 15 Feb

4:26 p.m.

New subject: Change in ...coreboot[master]: SMBIOS: Update BMC Interface Type field

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31421 )

Change subject: SMBIOS: Update BMC Interface Type field ......................................................................

SMBIOS: Update BMC Interface Type field

Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/31421 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Richard Spiegel richard.spiegel@silverbackltd.com --- M src/include/smbios.h 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Richard Spiegel: Looks good to me, approved

diff --git a/src/include/smbios.h b/src/include/smbios.h index 14badbc..a329d9a 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -484,6 +484,7 @@ SMBIOS_BMC_INTERFACE_KCS, SMBIOS_BMC_INTERFACE_SMIC, SMBIOS_BMC_INTERFACE_BLOCK, + SMBIOS_BMC_INTERFACE_SMBUS, };

typedef enum {

-- To view, visit https://review.coreboot.org/c/coreboot/+/31421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I68a8515adf5b29a080f8c5c5b7a96b28bca74676 Gerrit-Change-Number: 31421 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: merged

2113

days inactive

2114

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Patrick Georgi (Code Review)
Richard Spiegel (Code Review)