[S] Change in coreboot[master]: commonlib/fsp_relocate: Fix Coverity Issues

[Ed Sharma (Code Review)]

Attention is currently required from: Jonathan Zhang, Johnny Lin, Paul Menzel, Martin Roth.

Ed Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637 )

Change subject: commonlib/fsp_relocate: Fix Coverity Issues
......................................................................

Patch Set 4:

(2 comments)

File src/commonlib/fsp_relocate.c:

https://review.coreboot.org/c/coreboot/+/68637/comment/1cd0a736_5b9e1325 
PS4, Line 653: 				if (fih_offset) {
> Eddie, you may forgot to copy the coverity comment here.

Done

https://review.coreboot.org/c/coreboot/+/68637/comment/03f42017_b38455c0 
PS4, Line 654: 					pe_relocate(new_addr, section_data, fsp, *fih_offset);
Coverity Issue:
*** CID 1498390: Null pointer dereferences (FORWARD_NULL)
/src/commonlib/fsp_relocate.c: 650 in relocate_fvh()
644 printk(FSP_DBG_LVL, "TE image at offset %zx\n",
645 section_offset);
646 te_relocate(section_addr, section_data);
647 } else if (read_le8(&csh->Type) == EFI_SECTION_PE32) {
648 printk(FSP_DBG_LVL, "PE32 image at offset %zx\n",
649 section_offset);

CID 1498390: Null pointer dereferences (FORWARD_NULL)
            Dereferencing null pointer "fih_offset".

650 pe_relocate(new_addr, section_data, fsp, *fih_offset);
651 }
652
653 offset += data_size + data_offset;
654 /* Sections are aligned to 4 bytes. */
655 offset = ALIGN_UP(offset, 4);