Change in coreboot[master]: tpm: Allow separate handling of Google Ti50 TPM - coreboot-gerrit

25 Apr 2022


      Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter, Angel Pons, Jett Rink.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Allow separate handling of Google Ti50 TPM
......................................................................
Patch Set 17:
(1 comment)
File src/drivers/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/6ef314bf_e220e5ba 
PS17, Line 7: 
            : #define CR50_DID_VID	0x00281ae0L
            : #define TI50_DID_VID	0x504a6666L
Nit: Maybe look at moving these to a header file that can be included in both files?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63158
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986
Gerrit-Change-Number: 63158
Gerrit-PatchSet: 17
Gerrit-Owner: Jes Klinke jbk@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Jett Rink jettrink@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Martin L Roth martinroth@google.com
Gerrit-Attention: Jes Klinke jbk@chromium.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Jett Rink jettrink@google.com
Gerrit-Comment-Date: Sun, 24 Apr 2022 22:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment