build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31585 )
Change subject: ec/google/chromeec: fix the error status handling
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31585/4/src/mainboard/google/gru/mainboard.c
File src/mainboard/google/gru/mainboard.c:
https://review.coreboot.org/#/c/31585/4/src/mainboard/google/gru/mainboard.c...
PS4, Line 260: if (google_chromeec_set_usb_pd_role(port, USB_PD_CTRL_ROLE_FORCE_SINK) < 0)
line over 80 characters
https://review.coreboot.org/#/c/31585/4/src/mainboard/google/gru/mainboard.c...
PS4, Line 265: if (google_chromeec_set_usb_pd_role(port, USB_PD_CTRL_ROLE_TOGGLE_ON) < 0)
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c
Gerrit-Change-Number: 31585
Gerrit-PatchSet: 4
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Feb 2019 01:20:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment