Change in coreboot[master]: util/docker: Add sdcc to our build nodes
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46940 ) Change subject: util/docker: Add sdcc to our build nodes ...................................................................... util/docker: Add sdcc to our build nodes core-ec will need it. Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Signed-off-by: Patrick Georgi <pgeorgi@google.com> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/46940/1 diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 36b77d6..9449c05 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -20,6 +20,7 @@ RUN apt-get -y update && \ apt-get -y install \ meson ninja-build \ + sdcc \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean -- To view, visit https://review.coreboot.org/c/coreboot/+/46940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Gerrit-Change-Number: 46940 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-MessageType: newchange
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46940 ) Change subject: util/docker: Add sdcc to our build nodes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/46940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Gerrit-Change-Number: 46940 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 29 Oct 2020 12:44:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46940 ) Change subject: util/docker: Add sdcc to our build nodes ...................................................................... util/docker: Add sdcc to our build nodes core-ec will need it. Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46940 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index 36b77d6..9449c05 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -20,6 +20,7 @@ RUN apt-get -y update && \ apt-get -y install \ meson ninja-build \ + sdcc \ lua5.3 liblua5.3-dev default-jre-headless openssh-server && \ apt-get clean -- To view, visit https://review.coreboot.org/c/coreboot/+/46940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Gerrit-Change-Number: 46940 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46940 ) Change subject: util/docker: Add sdcc to our build nodes ...................................................................... Patch Set 2: Code-Review+2 Oh, sorry for not responding. I didn't get a notification. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/46940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Gerrit-Change-Number: 46940 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com> Gerrit-Comment-Date: Sat, 31 Oct 2020 18:16:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46940 ) Change subject: util/docker: Add sdcc to our build nodes ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/46940/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/46940/2//COMMIT_MSG@9 PS2, Line 9: core-ec will need it. What is core-ec? -- To view, visit https://review.coreboot.org/c/coreboot/+/46940 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id7d677a6f92ce266f893372a2540d77abb613707 Gerrit-Change-Number: 46940 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 01 Nov 2020 21:27:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (4)
-
Felix Singer (Code Review) -
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)