Change in ...coreboot[master]: qcs405 [temp]: Combine BB with QC-Sec for ROM boot
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29973 ) Change subject: qcs405 [temp]: Combine BB with QC-Sec for ROM boot ...................................................................... Patch Set 2: (39 comments) https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py File util/qualcomm/createxbl.py: https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@25 PS2, Line 25: # 09/04/15 et Added -x and -d to embed xbl_sec ELF trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@68 PS2, Line 68: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@84 PS2, Line 84: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@103 PS2, Line 103: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@113 PS2, Line 113: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@121 PS2, Line 121: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@144 PS2, Line 144: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@164 PS2, Line 164: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@172 PS2, Line 172: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@192 PS2, Line 192: header_format = 'reg' trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@223 PS2, Line 223: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@231 PS2, Line 231: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@232 PS2, Line 232: # Create hash table trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@235 PS2, Line 235: target_hash, trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@237 PS2, Line 237: secure_type = image_header_secflag) trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@245 PS2, Line 245: target_hash_hd, trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@254 PS2, Line 254: # Add the hash segment into the ELF trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@272 PS2, Line 272: def merge_elfs(env, trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@284 PS2, Line 284: mbn_tools.preprocess_elf_file(elf_in_file_name1) trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@289 PS2, Line 289: mbn_tools.preprocess_elf_file(elf_in_file_name2) trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@290 PS2, Line 290: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@294 PS2, Line 294: mbn_tools.preprocess_elf_file(elf_in_file_xbl_sec) trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@325 PS2, Line 325: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@364 PS2, Line 364: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@400 PS2, Line 400: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@477 PS2, Line 477: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@512 PS2, Line 512: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@614 PS2, Line 614: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@618 PS2, Line 618: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@621 PS2, Line 621: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@640 PS2, Line 640: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@674 PS2, Line 674: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@675 PS2, Line 675: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@681 PS2, Line 681: inp_data_offset = 0 trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@682 PS2, Line 682: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@689 PS2, Line 689: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@706 PS2, Line 706: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/createxbl.py@708 PS2, Line 708: trailing whitespace https://review.coreboot.org/#/c/29973/2/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py: https://review.coreboot.org/#/c/29973/2/util/qualcomm/mbn_tools.py@1167 PS2, Line 1167: # Check if a shifting is required to accomodate for the hash segment. 'accomodate' may be misspelled - perhaps 'accommodate'? -- To view, visit https://review.coreboot.org/c/coreboot/+/29973 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief4d92214cdc7ec06e90b0c7e73c11b6d6deddb9 Gerrit-Change-Number: 29973 Gerrit-PatchSet: 2 Gerrit-Owner: nsekar@codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-Comment-Date: Fri, 30 Nov 2018 14:09:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
build bot (Jenkins) (Code Review)