Attention is currently required from: Arthur Heymans, Jérémy Compostella, Martin L Roth, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75905?usp=email )
Change subject: Makefile.inc: Compress DSDT file
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75905/comment/a6da4412_806b7a60 :
PS7, Line 7: Compress DSDT file
Maybe mention the algorithm too?
https://review.coreboot.org/c/coreboot/+/75905/comment/47687f20_0fffcdae :
PS7, Line 9: Now
It’d be great if you referenced the commit introducing the feature.
https://review.coreboot.org/c/coreboot/+/75905/comment/04aaaf65_f76b5fff :
PS7, Line 12:
It’d be great, if you added timing and size data.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75905?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f555b1761c7ef4943d8de447ab299684403214b
Gerrit-Change-Number: 75905
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 21 Feb 2024 22:44:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment