Attention is currently required from: Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Julius Werner, Angel Pons.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization codes
......................................................................
Patch Set 16:
(3 comments)
File src/vendorcode/mediatek/Kconfig:
https://review.coreboot.org/c/coreboot/+/50294/comment/38cdd0be_862cf9a9
PS16, Line 3: config DEBUG_DRAM
: bool "Output verbose DRAM related debug messages"
: default y
: help
: This option enables additional DRAM related debug messages.
I wonder if we can revise it to something like [...] […]
What Angel suggested sounds good. @Xixi please make the change, and we should fix 8173 and 8183 in the same way (use DEBUG_RAM_SETUP) in the follow up changes.
File src/vendorcode/mediatek/mt8192/dramc/ANA_init_config.c:
PS13:
I assume that is more about SPDX specifically than about the license in general. […]
Got it, and I think Xixi also said they can add SPDX.
File src/vendorcode/mediatek/mt8192/dramc/ANA_init_config.c:
https://review.coreboot.org/c/coreboot/+/50294/comment/5da0b2e1_eae80abf
PS16, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
Just from a practical perspective: while I do love the GPL and want everyone to use it in general, p […]
I also prefer BSD3. @xixi please check with your internal teams and move to BSD3 if possible.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4
Gerrit-Change-Number: 50294
Gerrit-PatchSet: 16
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
reinauer@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 02:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment