Change in coreboot[master]: configs: Build config to run nvramcui with seabios on qemu

[Name of user not set (Code Review)]

Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35850 )

Change subject: configs: Build config to run nvramcui with seabios on qemu
......................................................................

configs: Build config to run nvramcui with seabios on qemu

Provide additional build config to run nvramcui as a secondary payload with seabios
on qemu. It resolves `Could not find Coreboot Option Table`.

Fixes: https://ticket.coreboot.org/issues/97

Change-Id: Ifae854bdc0092276c85ca198a33f0003cc3c1d0b
Signed-off-by: Himanshu Sahdev 
---
A configs/config.emulation_qemu_x86_i440fx_nvramcui
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/35850/1

diff --git a/configs/config.emulation_qemu_x86_i440fx_nvramcui b/configs/config.emulation_qemu_x86_i440fx_nvramcui
new file mode 100644
index 0000000..bccef90
--- /dev/null
+++ b/configs/config.emulation_qemu_x86_i440fx_nvramcui
@@ -0,0 +1,2 @@
+CONFIG_USE_OPTION_TABLE=y
+CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y

[Name of user not set (Code Review)]

Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35850

to look at the new patch set (#2).

Change subject: configs: Build config to run nvramcui with seabios on qemu
......................................................................

configs: Build config to run nvramcui with seabios on qemu

Provide additional build config to run nvramcui as a secondary payload with seabios
on qemu. It resolves `could not find coreboot option table`.

Fixes: https://ticket.coreboot.org/issues/97

Change-Id: Ifae854bdc0092276c85ca198a33f0003cc3c1d0b
Signed-off-by: Himanshu Sahdev 
---
A configs/config.emulation_qemu_x86_i440fx_nvramcui
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/35850/2

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35850 )

Change subject: configs: Build config to run nvramcui with seabios on qemu
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/35850/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35850/2//COMMIT_MSG@12 
PS2, Line 12: Fixes: https://ticket.coreboot.org/issues/97
it does not fix the issue described in the bug report

[Name of user not set (Code Review)]

Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35850 )

Change subject: configs: Build config to run nvramcui with seabios on qemu
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35850/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35850/2//COMMIT_MSG@12 
PS2, Line 12: Fixes: https://ticket.coreboot.org/issues/97
> it does not fix the issue described in the bug report

The config provided in the bug didn't enable 'Use CMOS for configuration values' under General Setup. 
CONFIG_USE_OPTION_TABLE=y resolves the same as I have tested using the provided config and linked the updated config as attachment on the issue itself.
I think this CL provides better indication about the same and is informative for a newbie.
I guess, needs some elaboration there on the issue, I thought attached config is self explanatory that time.

[XS] Change in coreboot[master]: configs: Build config to run nvramcui with seabios on qemu

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35850?usp=email )

Change subject: configs: Build config to run nvramcui with seabios on qemu
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.