Change in ...coreboot[master]: mb/google/octopus: Add 6GB dual-channel memory configuration
Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/31460
to review the following change.
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
mb/google/octopus: Add 6GB dual-channel memory configuration
Add 6GB dual-channel memory configuration for future use.
BUG=NONE BRANCH=octopus TEST=emerge-octopus coreboot
Change-Id: I36d6c704ac6708b29cc570a2209eeb32de6148b3 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/octopus/variants/baseboard/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/31460/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/memory.c b/src/mainboard/google/octopus/variants/baseboard/memory.c index d81d31f..0ff376f 100644 --- a/src/mainboard/google/octopus/variants/baseboard/memory.c +++ b/src/mainboard/google/octopus/variants/baseboard/memory.c @@ -189,6 +189,12 @@ .ch1_rank_density = LP4_8Gb_DENSITY, .ch1_dual_rank = 1, }, + /* Dual Channel Config 6GiB System Capacity */ + [7] = { + .speed = LP4_SPEED_2400, + .ch0_rank_density = LP4_12Gb_DENSITY, + .ch1_rank_density = LP4_12Gb_DENSITY, + }, };
static const struct lpddr4_cfg cbi_lp4cfg = {
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31460/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/memory.c:
https://review.coreboot.org/#/c/31460/1/src/mainboard/google/octopus/variant... PS1, Line 192: 6GiB I believe we are still waiting on confirmation about FSP changes required to support this.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31460/1/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/memory.c:
https://review.coreboot.org/#/c/31460/1/src/mainboard/google/octopus/variant... PS1, Line 192: 6GiB
I believe we are still waiting on confirmation about FSP changes required to support this.
Yes, we asked intel to share the verification result on b:124634885. Let's wait for the response.
shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
Patch Set 1:
I heard Intel confirmed to use 6GB memory. Let this change merged quickly to apply casta EVT board.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
Patch Set 1:
Patch Set 1:
I heard Intel confirmed to use 6GB memory. Let this change merged quickly to apply casta EVT board.
Yes, it's supported by MRC.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31460/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31460/1//COMMIT_MSG@11 PS1, Line 11: NONE pls put the bug number here. thanks.
Hello Aaron Durbin, Karthik Ramasubramanian, Seunghwan Kim, Kane Chen, Justin TerAvest, Marx Wang, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31460
to look at the new patch set (#2).
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
mb/google/octopus: Add 6GB dual-channel memory configuration
Add 6GB dual-channel memory configuration for future use.
BUG=b:124634885 BRANCH=octopus TEST=emerge-octopus coreboot
Change-Id: I36d6c704ac6708b29cc570a2209eeb32de6148b3 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/octopus/variants/baseboard/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/31460/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31460 )
Change subject: mb/google/octopus: Add 6GB dual-channel memory configuration ......................................................................
mb/google/octopus: Add 6GB dual-channel memory configuration
Add 6GB dual-channel memory configuration for future use.
BUG=b:124634885 BRANCH=octopus TEST=emerge-octopus coreboot
Change-Id: I36d6c704ac6708b29cc570a2209eeb32de6148b3 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31460 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/baseboard/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/baseboard/memory.c b/src/mainboard/google/octopus/variants/baseboard/memory.c index d81d31f..0ff376f 100644 --- a/src/mainboard/google/octopus/variants/baseboard/memory.c +++ b/src/mainboard/google/octopus/variants/baseboard/memory.c @@ -189,6 +189,12 @@ .ch1_rank_density = LP4_8Gb_DENSITY, .ch1_dual_rank = 1, }, + /* Dual Channel Config 6GiB System Capacity */ + [7] = { + .speed = LP4_SPEED_2400, + .ch0_rank_density = LP4_12Gb_DENSITY, + .ch1_rank_density = LP4_12Gb_DENSITY, + }, };
static const struct lpddr4_cfg cbi_lp4cfg = {
-
Furquan Shaikh (Code Review) -
Kane Chen (Code Review)
-
shkim (Code Review)