Attention is currently required from: Cliff Huang, Subrata Banik (OOO till 10/18).
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84718?usp=email )
Change subject: mb/google/fatcat: add pre-mem GPIO pad configure based on fw_config
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/fatcat/romstage.c:
https://review.coreboot.org/c/coreboot/+/84718/comment/a730e095_afadb141?usp... :
PS1, Line 8: pre_mem
@subratabanik@google.com, Cliff told me you request pre_mem instead of romstage. […]
Done
File src/mainboard/google/fatcat/variants/fatcat/fw_config.c:
https://review.coreboot.org/c/coreboot/+/84718/comment/fbcf7bd9_d909a59b?usp... :
PS1, Line 464: };
Remove `;`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iac1f637c21a9818512b224dc4cbe4a75dbc516ce
Gerrit-Change-Number: 84718
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik (OOO till 10/18)
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik (OOO till 10/18)
subratabanik@google.com
Gerrit-Comment-Date: Tue, 15 Oct 2024 18:00:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik (OOO till 10/18)
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com