Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39926 )
Change subject: [TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt ......................................................................
[TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt
This was lost during review.
Change-Id: I1f4ca20d67830dcf75b924d99474ac1613c36bd9 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/39926/1
diff --git a/src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb index 633ca81..4b65e82 100644 --- a/src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb @@ -33,6 +33,8 @@ device pci 3.3 off end # ME device pci 6.0 off end # PEG 2 chip southbridge/intel/i82801jx # Southbridge + + chip southbridge/intel/i82801jx # Southbridge register "gpe0_en" = "0x40"
register "sata_port_map" = "0x3f"
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39926 )
Change subject: [TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39926/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39926/1//COMMIT_MSG@9 PS1, Line 9: This was lost during review. We don't need it, though!
(comment to prevent accidental submission)
https://review.coreboot.org/c/coreboot/+/39926/1/src/mainboard/asus/p5qc/var... File src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39926/1/src/mainboard/asus/p5qc/var... PS1, Line 66: chip superio/winbond/w83667hg-a # Super I/O There used to be a subsystemid entry here, which was wrongly indented and had a "corresponding" end statement
https://review.coreboot.org/c/coreboot/+/39926/1/src/mainboard/asus/p5qc/var... PS1, Line 117: end The additional `end` was here.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39926
to look at the new patch set (#2).
Change subject: [TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt ......................................................................
[TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt
This was lost during review.
Change-Id: I1f4ca20d67830dcf75b924d99474ac1613c36bd9 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/asus/p5qc/variants/p5ql_pro/devicetree.cb 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/39926/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39926 )
Change subject: [TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39926/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39926/1//COMMIT_MSG@9 PS1, Line 9: This was lost during review.
We don't need it, though! […]
I know xD it's not supposed to be parseable... don't worry, I know what I'm doing, hehe ;)
Nico Huber has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39926 )
Change subject: [TEST] mb/asus/p5ql_pro: Re-add second southbridge to dt ......................................................................
Abandoned
just kidding
-
Angel Pons (Code Review) -
Nico Huber (Code Review)