Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: mb/google/octopus: Add API to disable USB devices ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33377/3/src/soc/intel/common/block/... File src/soc/intel/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/33377/3/src/soc/intel/common/block/... PS3, Line 79: Could not locate XHCI config in DT
Isn't this just looking for XHCI device? and not for config?
XHCI device is what I meant as config. I have changed it to mean device.
https://review.coreboot.org/c/coreboot/+/33377/3/src/soc/intel/common/block/... PS3, Line 86: config = port->chip_info; : if (!config) : continue;
This can be updated to use config_of(...) once this CL lands: https://review.coreboot. […]
I will do it once the CL lands. If this lands before that CL, then will do as a follow-up patch.
-
Karthik Ramasubramanian (Code Review)