Attention is currently required from: Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57318 )
Change subject: mb/google/guybrush: Reorganize bootblock_mainboard_early_init()
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/57318/comment/4eaf737e_454cc080
PS3, Line 56: dword = pm_read32(0x90);
: dword |= 1 << 16;
: pm_write32(0x90, dword);
:
: dword = pm_read32(0x74);
: dword |= 3 << 10;
: pm_write32(0x74, dword);
Yes, please refer to src/mainboard/google/guybrush/verstage. […]
oh, missed that one. will update it to use the defines i added in some other patch train, so that the git grep will then return something
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a6b8e2284e232c30c9f36ea7c6ab044e2644f7b
Gerrit-Change-Number: 57318
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 14:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment