Change in coreboot[master]: drivers/wifi/generic: Use pci_dev_* operations for device ops

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46028 )

Change subject: drivers/wifi/generic: Use pci_dev_* operations for device ops
......................................................................

drivers/wifi/generic: Use pci_dev_* operations for device ops

WiFi devices supported by the generic WiFi driver are PCIe devices
which need to be managed using the standard pci_dev_* operations to
read, set and enable resources. This change updates the
device_operations structure `wifi_generic_ops` to use the standard
pci_dev_* operations for these devices.

BUG=b:169802515
BRANCH=zork

Change-Id: I8b306259e205ecb963c0563000bd96ec6b978b8b
Signed-off-by: Furquan Shaikh 
---
M src/drivers/wifi/generic/generic.c
1 file changed, 6 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/46028/1

diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c
index dd53da3..b175f23 100644
--- a/src/drivers/wifi/generic/generic.c
+++ b/src/drivers/wifi/generic/generic.c
@@ -4,6 +4,7 @@
 #include <acpi/acpigen.h>
 #include <console/console.h>
 #include <device/device.h>
+#include <device/pci.h>
 #include <device/pci_def.h>
 #include <sar.h>
 #include <string.h>
@@ -236,9 +237,11 @@
    wifi_generic_fill_ssdt(dev, dev->chip_info);
 }

-static struct device_operations wifi_generic_ops = {
-	.read_resources		= noop_read_resources,
-	.set_resources		= noop_set_resources,
+struct device_operations wifi_generic_ops = {
+	.read_resources		= pci_dev_read_resources,
+	.set_resources		= pci_dev_set_resources,
+	.enable_resources	= pci_dev_enable_resources,
+	.ops_pci		= &pci_dev_ops_pci,
    .acpi_name		= wifi_generic_acpi_name,
    .acpi_fill_ssdt		= wifi_generic_fill_ssdt_generator,
 };

[Rob Barnes (Code Review)]

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46028 )

Change subject: drivers/wifi/generic: Use pci_dev_* operations for device ops
......................................................................

Patch Set 1: Code-Review+1

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46028 )

Change subject: drivers/wifi/generic: Use pci_dev_* operations for device ops
......................................................................

Patch Set 1: Code-Review+2

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46028 )

Change subject: drivers/wifi/generic: Use pci_dev_* operations for device ops
......................................................................

Patch Set 1: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46028 )

Change subject: drivers/wifi/generic: Use pci_dev_* operations for device ops
......................................................................

Patch Set 1: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46028 )

Change subject: drivers/wifi/generic: Use pci_dev_* operations for device ops
......................................................................

drivers/wifi/generic: Use pci_dev_* operations for device ops

WiFi devices supported by the generic WiFi driver are PCIe devices
which need to be managed using the standard pci_dev_* operations to
read, set and enable resources. This change updates the
device_operations structure `wifi_generic_ops` to use the standard
pci_dev_* operations for these devices.

BUG=b:169802515
BRANCH=zork

Change-Id: I8b306259e205ecb963c0563000bd96ec6b978b8b
Signed-off-by: Furquan Shaikh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46028
Tested-by: build bot (Jenkins) 
Reviewed-by: Rob Barnes 
Reviewed-by: Duncan Laurie 
Reviewed-by: Michael Niewöhner 
Reviewed-by: Karthik Ramasubramanian 
---
M src/drivers/wifi/generic/generic.c
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Duncan Laurie: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved
  Michael Niewöhner: Looks good to me, but someone else must approve
  Rob Barnes: Looks good to me, but someone else must approve

diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c
index dd53da3..b175f23 100644
--- a/src/drivers/wifi/generic/generic.c
+++ b/src/drivers/wifi/generic/generic.c
@@ -4,6 +4,7 @@
 #include <acpi/acpigen.h>
 #include <console/console.h>
 #include <device/device.h>
+#include <device/pci.h>
 #include <device/pci_def.h>
 #include <sar.h>
 #include <string.h>
@@ -236,9 +237,11 @@
    wifi_generic_fill_ssdt(dev, dev->chip_info);
 }

-static struct device_operations wifi_generic_ops = {
-	.read_resources		= noop_read_resources,
-	.set_resources		= noop_set_resources,
+struct device_operations wifi_generic_ops = {
+	.read_resources		= pci_dev_read_resources,
+	.set_resources		= pci_dev_set_resources,
+	.enable_resources	= pci_dev_enable_resources,
+	.ops_pci		= &pci_dev_ops_pci,
    .acpi_name		= wifi_generic_acpi_name,
    .acpi_fill_ssdt		= wifi_generic_fill_ssdt_generator,
 };