Attention is currently required from: Karthik Ramasubramanian, Kun Liu.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81817?usp=email )
Change subject: mb/google/brox: Create lotso variant ......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/brox/variants/lotso/gpio.c:
https://review.coreboot.org/c/coreboot/+/81817/comment/2ea25b2d_47fa37fe : PS5, Line 9: const struct pad_config *variant_gpio_table(size_t *num) : { : *num = 0; : return NULL; : } : : const struct pad_config *variant_early_gpio_table(size_t *num) : { : *num = 0; : return NULL; : } I think that you don't need these override functions if they are just empty?
https://review.coreboot.org/c/coreboot/+/81817/comment/11d1e7f1_1788a203 : PS5, Line 26: const struct pad_config *variant_romstage_gpio_table(size_t *num) : { : *num = 0; : return NULL; : } : same here?