Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30103 )
Change subject: src/cpu/intel: Set get_ia32_fsb function common
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30103/2/src/cpu/x86/lapic/apic_timer.c
File src/cpu/x86/lapic/apic_timer.c:
https://review.coreboot.org/#/c/30103/2/src/cpu/x86/lapic/apic_timer.c@46
PS2, Line 46: static int set_timer_fsb(void)
: {
: car_set_var(g_timer_fsb, get_ia32_fsb());
: return 0;
return value must depend on whether g_timer_fsb is sane.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I232bf88de7ebba6ac5865db046ce79e9b2f3ed28
Gerrit-Change-Number: 30103
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 08 Dec 2018 17:28:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment