Attention is currently required from: Paul Menzel, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69543 )
Change subject: drivers/i2c/rv3028c7: Add ACPI generation callbacks
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69543/comment/9420e64b_9e4d11e5
PS3, Line 9: Added
Present tense: Add
Done
https://review.coreboot.org/c/coreboot/+/69543/comment/54fcd817_a0ee72c9
PS3, Line 12: added
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/69543/comment/43182073_21e0a7cf
PS3, Line 19: HID (a proper kernel patch
: is pending).
HID. (A proper kernel patch […]
I think simpler is better here so let's get rid of the parens.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69543
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b8cf5c8dc551439755992ff05b6693e91cc3f21
Gerrit-Change-Number: 69543
Gerrit-PatchSet: 4
Gerrit-Owner: Jan Samek
jan.samek@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 14:00:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment