Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61800 )
Change subject: soc/mediatek: Fix printing SPM version
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61800/comment/86c305b0_fee0f535
PS1, Line 16: none
Do we need to cherry-pick this change to asurada or cherry branches?
For mt8192 there's \0 at the end. For mt8195 there isn't, but I don't remember seeing this problem on cherry. That said, I think we should still fix the firmware branches.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfeb686539dc20cf5b78de77c27bdbb137b5d624
Gerrit-Change-Number: 61800
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Feb 2022 00:23:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment